Description

Super Mario Bros. X is a fairly popular Mario fangame created by Andrew Spinks (yes, Redigit, the same guy who now has developed Terraria) in 2009. It was coded entirely in Visual Basic 6. Development ceased in 2011 prior to the release of version 1.3, but the community has since taken over. Recently, a modification for SMBX was created called LunaDLL. This extension allowed for some assembly like code to be executed on a per level basis. Mostly memory hacks. After, Kevsoft (co-developer of SMBX successor PGE) created his own extension to LunaDLL called LunaLua. This refined the LunaDLL experience, allowing Lua code to be executed in levels. With LunaLua came modifications to use SDL for the sound drivers allowing now for full sound compatibility with Linux.

Changes Outside of POL/Wine

None needed :)

Errors and Problems

As seen in the screenshots, the launcher is unable to load the splash screen. I have talked to the supermariobrosx.org webmaster about it and he is looking into it.

Script

Note: I forked the original script author's repo and publish the latest versions of the script there. The repo is here

Screenshots

Notes

While the level editor does indeed work, it is highly recommend you use PGE as the editor. This is the successor to SMBX and retains full compatibility with SMBX's formats and is coded in C++, has native ports to Linux, and is just plain better (in my opinion anyway). PGE

Note to Moderators

I have left/top/22/64/48 icons, I'm just not sure if I should upload them imgur, submit them here, or what. That part isn't entirely clear and I apologise for this :)

Edité par MrMiketheripper

Small script update as x10Hosting thought it would be funny to delete my lunalua-complete.zip.

 

Hopefully the last update, containing an always updated link thanks to Wohlstand.

 

Edité par MrMiketheripper

Hi,

Ok, my script review:

That's a bit short, to avoid any possibility of collisions script_checker.sh recommends at least 5 characters, but there's no good reason nowadays not to use full names like SuperMarioBrosX

You create lots of variables, you could have used one for the Wine version used...

All user-oriented messages should support localization (http://wiki.playonlinux.com/index.php/Scripting_-_Chapter_10:_Script_Translation)

 Several things here, $REPERTOIRE is deprecated and one should use $POL_USER_ROOT instead, and POL_SetupWindow_download has been superseded by POL_Download; But most importantly since the resources cache is never trimmed, scripts should only put reusable files there, validated thru the use of a hash as in POL_Download_Resource. That's exactly the wrong place for a temporary file, either put it in $POL_USER_ROOT/tmp, or use POL_System_TmpCreate.

 Use of winetricks is scripts has been obsoleted since at least when I learned about PlayOnLinux, almost four years ago. It can't say before that. Anyway, all those "verbs" have their "components" counterparts, just use POL_Call POL_Install_vbrun6, etc.

Don't hardcode virtual drive path $POL_USER_ROOT/wineprefix/$PREFIX, use $WINEPREFIX instead

You can use POL_System_unzip instead of unzip, the added benefit is that in case of error in unzip, the user will be warned instead of the error being silently ignored.

That's it, but the use of winetricks and or the resources cache for temporary files are both no-gos for adding it to the official scripts repository.

Regards,

Pierre.

I will make those modifications asap.

 

One thing though: by downloading from the get.php link Wohlstand uses, the zip name could be different is there a way to peek at the file name either through bash scripting or POL calls?

 

EDIT: https://raw.githubusercontent.com/Luigifan/playonlinux/master/smbx.pol

 

How's this? I'm not able to access my Linux machine at the moment so I'm unable to test.

Edité par MrMiketheripper