Connexion

Dimanche 9 Octobre 2022 à 20:24

It is about time this fix gets activated!
For the meantime here is a little DIY recipe:
1. locate the POL installer file:
ls $HOME/.PlayOnLinux/install

Dimanche 9 Octobre 2022 à 20:26

2. change line 80 in the installer file as described above.
new line: FILE=`cat $INSTALLER | grep ".exe" | grep -v "Download" | head -1 | cut -d "t" -f 2`

Dimanche 9 Octobre 2022 à 20:28

3. copy the patched installer file to
the POL launcher directory $HOME/.PlayOnLinux/shortcuts/install

Dimanche 9 Octobre 2022 à 20:29

4. manually run the installer
playonlinux --run install

VolkerFroehlich Samedi 30 Janvier 2021 à 2:10

VolkerFroehlich

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

Hi,
The new, restructured and commented code may need a bit longer to digest and to be approved ;o)

The users can either locate an installer on their computer or chose the automated download.
If the download option is selected, the script will always try to download the newest installer version.
(You can test this by setting an invalid file name e.g. FILE="ThisFilenameIsWrong" in the script.)
As a fallback (in case the Editor changes the behavior of the download web page) the script asks the user to manually provide the download URL.

Have Fun!
Volker Fröhlich

Differences

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

@@ -2,37 +2,109 @@
 [ "$PLAYONLINUX" = "" ] && exit 0
 source "$PLAYONLINUX/lib/sources"
  
-#
-# CHANGELOG
-# [ ? ] (2010 ?)
-#   Initial script.
-# [Dadu042] (2020-08-17 16-00)
-#   Fix by Volker F (add 'cd' because folder might write protected).
-  
+#   Volker Froehlich (check download page for latest version).
+######################
+# set global parameters
 TITLE="Mp3tag"
- 
 PREFIX="mp3tag"
-AUTHOR="Hamster28"
- 
-FILE="mp3tagv302setup.exe"
-MD5="1483de5d4db3a9a5fbf0ab63aade18d5"
- 
+AUTHOR="VolkerFroehlich"
+EDITOR="Florian Heidenreich"
+EDITOR_URL="http://www.mp3tag.de/"
+### FILE="ThisFilenameIsWrong" <== you can use an invalid file name
+### and this script will still download the current install version!!!
+### For script efficiency we still provide the currently available file name
+FILE="mp3tagv305setup.exe"
+### MD5 no longer supported by the Editor, we still keep the parameter
+### for future changes
+MD5=""
+DOWNLOAD_PATH=http://download.mp3tag.de/
+######################
+# show POL Window
 POL_SetupWindow_Init
-
-# Depreciated as of 2020
-# POL_SetupWindow_SetID 714
-
-POL_SetupWindow_presentation "$TITLE" "Florian Heidenreich" "http://www.mp3tag.de/" "$AUTHOR" "$PREFIX"
- 
+POL_SetupWindow_presentation "$TITLE" "$EDITOR" "$EDITOR_URL" "$AUTHOR" "$PREFIX"
+######################
+# create PREFIX environment
 POL_Wine_SelectPrefix "$PREFIX"
 POL_Wine_PrefixCreate
 Set_OS "win7"
-
-cd "$WINEPREFIX/drive_c"
-POL_Download "http://download.mp3tag.de/$FILE" "$MD5"
-POL_Wine_WaitBefore "$TITLE"
-POL_Wine "$FILE"
-POL_Shortcut "mp3tag.exe" "$TITLE" "" "" "AudioVideo;Audio;AudioVideoEditing;Music;"
- 
+POL_System_TmpCreate "$PREFIX"
+PWD_OLD=`pwd`
+cd "$POL_System_TmpDir" || POL_Debug_Fatal "Unable to change directory"
+######################
+# let user choose
+# a) local installer vs. 
+# b) download from $DOWNLOAD_PATH
+INSTALLER=""
+DOWNLOAD_FULLPATH=$DOWNLOAD_PATH$FILE
+POL_SetupWindow_InstallMethod "LOCAL,DOWNLOAD"
+if [ "$INSTALL_METHOD" = "LOCAL" ]; then
+######################
+# user selects installer
+   POL_SetupWindow_browse "$(eval_gettext 'Please select the setup file to run.')" "$TITLE"
+   INSTALLER="$APP_ANSWER"
+elif [ "$INSTALL_METHOD" = "DOWNLOAD" ]; then
+######################
+# download installer
+   DOWNLOAD_LINK=$DOWNLOAD_FULLPATH
+   DOWNLOAD_FILE=$(basename "$DOWNLOAD_FULLPATH")
+   POL_Download "$DOWNLOAD_LINK" "$MD5"
+   INSTALLER="$POL_System_TmpDir/$DOWNLOAD_FILE"
+fi
+######################
+# if no downloaded file exists, we ask user
+# to manually enter the download URL 
+if [[ -z "$INSTALLER" || ! -f "$INSTALLER" ]]; then
+   MSG="Installation file not found ($INSTALLER)"
+   POL_SetupWindow_message "$(eval_gettext '$MSG')" "$TITLE"
+   DOWNLOAD_LINK="$DOWNLOAD_FULLPATH"
+   DOWNLOAD_FILE=$(basename "$DOWNLOAD_LINK")
+   POL_SetupWindow_textbox "Enter/correct download URL:" "$TITLE" "$DOWNLOAD_LINK"
+   DOWNLOAD_LINK="$APP_ANSWER"
+   DOWNLOAD_FILE=$(basename "$DOWNLOAD_LINK")
+   POL_Download "$DOWNLOAD_LINK" "$MD5"
+   INSTALLER="$POL_System_TmpDir/$DOWNLOAD_FILE"
+fi
+###########################
+# We check if the downloaded file is too small for an executable
+# In case we tried to download an incorrect file
+# the HTML page was downloaded instead
+# (That behaviour of the Editors website might change in future)
+if [ -f "$INSTALLER" ]; then
+   file_size_kb=`du -k "$INSTALLER" | cut -f1`
+   if [ "$file_size_kb" -lt 1000 ]; then
+###########################
+# We locate the current installation file name 
+# on the HTML page and download it
+# We assume the file name is "mp3t"<SomeVersionRelatedTextHere>tup.exe"
+# (That file name structure might change in future)
+       FILE=`cat $INSTALLER | grep ".exe" | grep -v "Download" | cut -d "t" -f 2`
+       rm $INSTALLER 2>/dev/null
+       FILE="mp3t${FILE}tup.exe"
+       DOWNLOAD_LINK=$DOWNLOAD_PATH$FILE
+       POL_Download "$DOWNLOAD_LINK" "$MD5"
+       INSTALLER="$POL_System_TmpDir/$FILE"
+   fi
+fi
+###########################
+# Run Wine installation
+if [ -f "$INSTALLER" ]; then
+   MSG="Installation in progress."
+   POL_SetupWindow_wait "$(eval_gettext '$MSG')" "$TITLE"
+   POL_Wine_WaitBefore "$TITLE"
+   POL_Wine "$INSTALLER"
+###########################
+# Get Installed Version
+   VERSION_INSTALLED=""
+   POL_Debug_Message "# WINEPREFIX: $WINEPREFIX"
+   VERSION_FILE="$WINEPREFIX/drive_c/Program Files/Mp3tag/Mp3tagVersion.txt"
+   POL_Debug_Message "# VERSION_FILE: $VERSION_FILE"
+   [ -f "$VERSION_FILE" ] && VERSION_INSTALLED=`head -2 "$VERSION_FILE" | grep VERSION | cut -d " " -f 5`
+POL_Debug_Message "# VERSION_INSTALLED: $VERSION_INSTALLED"
+   LAUNCHER="$TITLE"
+   [ ! -z "$VERSION_INSTALLED" ] && LAUNCHER="$TITLE-v$VERSION_INSTALLED"
+POL_Debug_Message "# LAUNCHER: $LAUNCHER"
+   POL_Shortcut "mp3tag.exe" "$LAUNCHER" "" "" "AudioVideo;Audio;AudioVideoEditing;Music;"
+fi 
+cd $PWD_OLD
 POL_SetupWindow_Close
-exit
\ No newline at end of file
+exit

Nouveau code source

100

101

102

103

104

105

106

107

108

109

110

#!/bin/bash
[ "$PLAYONLINUX" = "" ] && exit 0
source "$PLAYONLINUX/lib/sources"
 
#   Volker Froehlich (check download page for latest version).
######################
# set global parameters
TITLE="Mp3tag"
PREFIX="mp3tag"
AUTHOR="VolkerFroehlich"
EDITOR="Florian Heidenreich"
EDITOR_URL="http://www.mp3tag.de/"
### FILE="ThisFilenameIsWrong" <== you can use an invalid file name
### and this script will still download the current install version!!!
### For script efficiency we still provide the currently available file name
FILE="mp3tagv305setup.exe"
### MD5 no longer supported by the Editor, we still keep the parameter
### for future changes
MD5=""
DOWNLOAD_PATH=http://download.mp3tag.de/
######################
# show POL Window
POL_SetupWindow_Init
POL_SetupWindow_presentation "$TITLE" "$EDITOR" "$EDITOR_URL" "$AUTHOR" "$PREFIX"
######################
# create PREFIX environment
POL_Wine_SelectPrefix "$PREFIX"
POL_Wine_PrefixCreate
Set_OS "win7"
POL_System_TmpCreate "$PREFIX"
PWD_OLD=`pwd`
cd "$POL_System_TmpDir" || POL_Debug_Fatal "Unable to change directory"
######################
# let user choose
# a) local installer vs. 
# b) download from $DOWNLOAD_PATH
INSTALLER=""
DOWNLOAD_FULLPATH=$DOWNLOAD_PATH$FILE
POL_SetupWindow_InstallMethod "LOCAL,DOWNLOAD"
if [ "$INSTALL_METHOD" = "LOCAL" ]; then
######################
# user selects installer
        POL_SetupWindow_browse "$(eval_gettext 'Please select the setup file to run.')" "$TITLE"
        INSTALLER="$APP_ANSWER"
elif [ "$INSTALL_METHOD" = "DOWNLOAD" ]; then
######################
# download installer
        DOWNLOAD_LINK=$DOWNLOAD_FULLPATH
        DOWNLOAD_FILE=$(basename "$DOWNLOAD_FULLPATH")
        POL_Download "$DOWNLOAD_LINK" "$MD5"
        INSTALLER="$POL_System_TmpDir/$DOWNLOAD_FILE"
fi
######################
# if no downloaded file exists, we ask user
# to manually enter the download URL 
if [[ -z "$INSTALLER" || ! -f "$INSTALLER" ]]; then
        MSG="Installation file not found ($INSTALLER)"
        POL_SetupWindow_message "$(eval_gettext '$MSG')" "$TITLE"
        DOWNLOAD_LINK="$DOWNLOAD_FULLPATH"
        DOWNLOAD_FILE=$(basename "$DOWNLOAD_LINK")
        POL_SetupWindow_textbox "Enter/correct download URL:" "$TITLE" "$DOWNLOAD_LINK"
        DOWNLOAD_LINK="$APP_ANSWER"
        DOWNLOAD_FILE=$(basename "$DOWNLOAD_LINK")
        POL_Download "$DOWNLOAD_LINK" "$MD5"
        INSTALLER="$POL_System_TmpDir/$DOWNLOAD_FILE"
fi
###########################
# We check if the downloaded file is too small for an executable
# In case we tried to download an incorrect file
# the HTML page was downloaded instead
# (That behaviour of the Editors website might change in future)
if [ -f "$INSTALLER" ]; then
        file_size_kb=`du -k "$INSTALLER" | cut -f1`
        if [ "$file_size_kb" -lt 1000 ]; then
###########################
# We locate the current installation file name 
# on the HTML page and download it
# We assume the file name is "mp3t"<SomeVersionRelatedTextHere>tup.exe"
# (That file name structure might change in future)
                FILE=`cat $INSTALLER | grep ".exe" | grep -v "Download" | cut -d "t" -f 2`
                rm $INSTALLER 2>/dev/null
                FILE="mp3t${FILE}tup.exe"
                DOWNLOAD_LINK=$DOWNLOAD_PATH$FILE
                POL_Download "$DOWNLOAD_LINK" "$MD5"
                INSTALLER="$POL_System_TmpDir/$FILE"
        fi
fi
###########################
# Run Wine installation
if [ -f "$INSTALLER" ]; then
        MSG="Installation in progress."
        POL_SetupWindow_wait "$(eval_gettext '$MSG')" "$TITLE"
        POL_Wine_WaitBefore "$TITLE"
        POL_Wine "$INSTALLER"
###########################
# Get Installed Version
        VERSION_INSTALLED=""
        POL_Debug_Message "# WINEPREFIX: $WINEPREFIX"
        VERSION_FILE="$WINEPREFIX/drive_c/Program Files/Mp3tag/Mp3tagVersion.txt"
        POL_Debug_Message "# VERSION_FILE: $VERSION_FILE"
        [ -f "$VERSION_FILE" ] && VERSION_INSTALLED=`head -2 "$VERSION_FILE" | grep VERSION | cut -d " " -f 5`
POL_Debug_Message "# VERSION_INSTALLED: $VERSION_INSTALLED"
        LAUNCHER="$TITLE"
        [ ! -z "$VERSION_INSTALLED" ] && LAUNCHER="$TITLE-v$VERSION_INSTALLED"
POL_Debug_Message "# LAUNCHER: $LAUNCHER"
        POL_Shortcut "mp3tag.exe" "$LAUNCHER" "" "" "AudioVideo;Audio;AudioVideoEditing;Music;"
fi
cd $PWD_OLD
POL_SetupWindow_Close
exit

Réponses

Mercredi 19 Mai 2021 à 11:30

Script approved.

Edité par VolkerFroehlich

VolkerFroehlich Samedi 30 Janvier 2021 à 0:02

VolkerFroehlich

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

Hi,
I just came back to this site after being several months away and, I am sorry to see the disappointed people giving negative ratings when set-up versions do change. I have updated the script for the new version 305 which came out today. However, the program versions change frequently, so in a few weeks this script will no longer work again. Therefore a general remark how everybody quickly may be able to fix such issues themselves:
- I cannot say too much about PlayOnMac, but should be very similar - also seems to be soon an Apple version available https://mp3tag.app/ :o) -
If PlayOnlinux fails, the installation script will remain in the POL root directory ($HOME/.PlayOnLinux) with the file name "install".
Hence, you can edit and fix the script and, in this case modify these two lines:
FILE="mp3tagv305setup.exe"
MD5=""
Then you can run this file "install" from the Tools Menu as a local script. Alternatively you can move the file to the subdirectory $HOME/.PlayOnLinux/shortcuts and also rename it. When you launch PlayOnLinux ou can see it in the choice of available "installed programs" and run it directly. Btw - that is also how I am (and most likely others are) debugging and testing scripts.
As a fall back on such version errors, I plan to improve the script: if the download fails, the user should have the choice to manually enter a download filename of a newer version, or else to locate an already downloaded set-up file on the hard disk... sure, this will take a bit more time and testing.
Volker Fröhlich

Differences

Nouveau code source

Réponses

Edité par VolkerFroehlich

ferdesign Dimanche 20 Décembre 2020 à 12:52

ferdesign

Messages

Can you update the script to fetch the latest - mp3tagv304asetup.exe - instead?
At the moment, it's throwing error it can't download http://download.mp3tag.de/mp3tagv302asetup.exe.

Thanks!

Réponses

Dadu042 Lundi 17 Aoüt 2020 à 16:45

Dadu042

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

Ok with wine 5.0.2

Differences

Nouveau code source

Réponses

VolkerFroehlich Samedi 15 Aoüt 2020 à 19:01

VolkerFroehlich

Messages

POL UI fails to download and install "mp3tagv302setup.exe"

[sorry in advance if this post should be raised elsewhere in the forum - i am a novice to POL and would like to contribute]

This is most likely a general bug in POL 4.3.4 outside of this script. It can consistently be replicated with Ubuntu 19.10 and 20.04 and I even upgraded manually to the latest wine version 5.0.2.

When running the Mp3tag install from within POL by selecting and clicking on the Mp3tag Icon under available installers, the UI is executing the installation with no issues, until the download of the sofware fails. POL is showing the correct download link. The error message reads

"An error happened during download. Do you want to retry?"

Then any retry fails as well. The installation obviously gets stuck with script command

POL_Download "http://download.mp3tag.de/$FILE" "$MD5"

The file playonlinux.log created in the wineprefix directory does just end abruptly without much info:

...
[08/15/20 18:33:20] - This is a 32bits prefix!
[08/15/20 18:33:24] - Running wine- cmd /c echo %ProgramFiles% (Working directory : /usr/share/playonlinux/python)
C:\Program Files
[08/15/20 18:33:28] - Running wine- regedit /home/[myusername]/.PlayOnLinux//tmp/regkey.reg (Working directory : /usr/share/playonlinux/python)
[08/15/20 18:33:28] - Content of /home/[myusername]/.PlayOnLinux//tmp/regkey.reg
-----------
REGEDIT4

[HKEY_CURRENT_USER\Software\Wine]
"Version"="win7"
-----------

I strongly believe this download error is not an issue linked to this Windows program or script, but rather a bug in POL GUI.

You can successfully run the identical Mp3tag script in POL with menu "Run a local script". After the previously failed download the Mp3tag install script remains in the .PlayOnLinux root folder as a PGP signed script file called "install". And, this file runs perfectly if started as a local script.

Réponses

Lundi 17 Aoüt 2020 à 15:49

Error identified: POL library functions are not checking if the download directory is writable.

Python file scripts.lib:
POL_Download ()
# Download a file and place it in the current directory
:
POL_SetupWindow_download ... "$PWD/$FILE"
:

The download will fail in python file setupwindowlib if the current working directory $PWD is not writable.

When double-clicking the Mp3tag script Icon the current working directory is '/usr/share/playonlinux/python' and only root has write access there.

The fix to the Mp3tag install script is easy - just insert cd "/tmp" before POL_Download "http://download.mp3tag.de/\$FILE" "\$MD5"
Then the Mp3tag installation script will run the installation without error.
However, I do suggest to introduce a fix on POL generic level, as in "Ubuntu Software" I do see several complains about POL where installations fail - perhaps because of the same issue!?

Lundi 17 Aoüt 2020 à 16:45

Thanks, I had the issue on Xubuntu 18.04

Edité par VolkerFroehlich

MrSoup678 Mardi 11 Aoüt 2020 à 16:13

MrSoup678

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

Updated to v3.02.

Differences

Nouveau code source

Réponses

Mardi 11 Aoüt 2020 à 18:44

script approved.

Edité par MrSoup678

Hamster28 Mardi 14 Avril 2020 à 11:16

Hamster28

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

Hello,

Mp3tag has been updated to version 3.01.

The old download link isn't valid anymore this causes the installer to fail.

I just replaced the filename and md5 hash.

I did a manual install of version 3.01 and succesfully tried out the following actions: installation, browse to a folder with already tagged mp3 files, display the tags in the tag panel. So This features should also work when using the new installer.

Differences

Nouveau code source

Réponses

Mardi 14 Avril 2020 à 12:56

Script approved.

mihawk90 Mercredi 10 Avril 2019 à 1:03

mihawk90

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

update Mp3tag version
use System wine instead of ancient WINE version (doesn't even create prefix on my current Fedora 29)
Win7 instead of XP
remove unused Debug_Init
add actual software author
removed Luna theme as it's rather personal (and doesn't work well with GTK theming)
add categories for Shortcut

Differences

Nouveau code source

Réponses

Lundi 20 Mai 2019 à 9:09

Thank you for the script (I approved it) however it need also this: http://wiki.playonlinux.com/index.php/Scripting_-_Chapter_9:_Standardization

Edité par mihawk90

djdennisj Jeudi 24 Mai 2018 à 7:58

djdennisj

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Differences

Nouveau code source

Réponses

Jeudi 24 Mai 2018 à 8:00

This is the update for 2.87. Msg me at Dennis@TheCreativeMusicDJ.com if you need a newer script for MP3Tag in the future. Always happy to help!

gh7531

Jeudi 2 Aoüt 2018 à 21:39

Hey, an update to 2.89 would be nice. If you have the spare time of course.

tecneeq Dimanche 25 Mars 2018 à 15:45

tecneeq

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

Download for installer has been removed. New installer and checksum are below.

Differences

Nouveau code source

Réponses

djdennisj Mercredi 16 Aoüt 2017 à 15:39

djdennisj

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

As promised, someone hit me up to create a script for the 2.83 release so here it is, tested and working. When 2.84 comes out, contact me again and I'll try to expedite my fix the next time!

Differences

Nouveau code source

Réponses

djdennisj Vendredi 9 Juin 2017 à 10:34

djdennisj

Warning

Cette mise à jour n'a pas été approuvée par l'équipe.
Utilisez-la à vos risques et périls

Essayer ce patch

Messages

111

Differences

Nouveau code source

Réponses

Vendredi 9 Juin 2017 à 10:35

This is working code to install mp3tag 2.82. Enjoy.

durrie

Samedi 1 Juillet 2017 à 14:20

Hi djdennisj, 283 is now live on the MP3Tag site so the MD5 and files are mismatched. I understand what this is and why it happens and where to change these values in the scripts but how to I save and run this so I can continue to upgrade on the fly by myself...

durrie

Samedi 1 Juillet 2017 à 14:20

FILE="mp3tagv283setup.exe"
MD5=“e53bc0ca0c2a5c47aceeaf38e8760c8a"

Mercredi 16 Aoüt 2017 à 15:25

durrie: Change the MD5 to the one being generated using the 2.83 version. I'm posting a new post with the 2.83 code right now, btw.

scotthva5 Vendredi 10 Mars 2017 à 20:18

scotthva5

Messages

Same issue as the poster below me: script needs to be updated for version 2.81. Ran fine as a generic install though so the outdated script is not a problem.

Réponses

Grantp

Lundi 13 Mars 2017 à 12:39

Hi scotthva5, I am very new to Linux. I have no idea how to run as a generic install. Could you please point me in right direction, it would be very much appreciated.