The forum

Hi there,

I just finished a script that installs Adwords Editor 8.0.1
Wine version : 1.2
Distribution : Debian
Distribution Version : Sid (64 bit)

Because it's my first script I am not sure how to submit one. So apart from this post I tried uploading one through the Members' add script page (http://www.playonmac.com/repository/new.php). in which I send a wrong version without the soft download.

Let me know !

Screenshot :


Cheers
LeTic

#!/bin/bash
# Date: (2010-09-15  12-39)
# Last revision: (2010-09-15  15-57)
# Wine version used: 1.2
# Distribution used to test: Debian Sid 64bit
# Author: LeTic
# Licence: http://www.google.com/intl/en/adwordseditor/terms.html
# Depend:
 
[ "$PLAYONLINUX" = "" ] && exit 0
source "$PLAYONLINUX/lib/sources"
 
NAME="Adwords Editor"
PREFIX="AdwordsEditor"
URL="http://dl.google.com/adwords_editor/8.0.1/win32/en-US/adwords_editor_en-US.msi"
 
DOWNLOAD="Download in progress..."
INSTALLATION="Installation in progress..."
POLEND="$NAME has been installed succesfully"
 
wget	 http://www.google.com/images/logos/adwords_editor_logo.gif --output-document="$REPERTOIRE/tmp/leftnotscaled.gif"
convert "$REPERTOIRE/tmp/leftnotscaled.gif" -rotate 270 -scale 52x356\\! "$REPERTOIRE/tmp/left.jpeg"
 
wget "http://4.bp.blogspot.com/_q0bscNXWyfo/TJCIb0Hi34I/AAAAAAAABGw/fp5DypIjaYI/s1600/logo+blog.JPG" --output-document="$REPERTOIRE/tmp/topnotscaled.jpeg"
convert "$REPERTOIRE/tmp/topnotscaled.jpeg" -scale 60x60\\! "$REPERTOIRE/tmp/top.jpeg"
 
POL_SetupWindow_Init "$REPERTOIRE/tmp/top.jpeg" "$REPERTOIRE/tmp/left.jpeg"
 
POL_SetupWindow_presentation "$NAME" "Google Inc" "http://www.google.com/intl/en/adwordseditor/index.html" "LeTic" "$PREFIX"
 
select_prefix "$REPERTOIRE/wineprefix/$PREFIX"
POL_SetupWindow_prefixcreate
 
POL_SetupWindow_install_wine "1.2"

Set_WineVersion_Assign "1.2" "$NAME"
 
PROGRAMFILES="Program Files"
POL_LoadVar_PROGRAMFILES
 
#Install vcrun2005
POL_Call POL_Install_vcrun2005
POL_Call POL_Install_gecko

cd "$REPERTOIRE/tmp/"
 
POL_SetupWindow_download "$DOWNLOAD" "$NAME" "$URL"
POL_SetupWindow_wait_next_signal "$INSTALLATION" "$NAME"
msiexec /i adwords_editor_en-US.msi /q
POL_SetupWindow_detect_exit

rm -rf adwords_editor_en-US.msi
 
#convert "$REPERTOIRE/tmp/top.jpeg" -scale 32x32\\! "$REPERTOIRE/icones/32/$NAME"
convert ~/.local/share/icons/*__19536f6e05de1cfef02b79.png -scale 32x32\\! "$REPERTOIRE/icones/32/$NAME"
 
POL_SetupWindow_make_shortcut "$PREFIX" "$PROGRAMFILES/Google/Google AdWords Editor" "adwords_editor.exe" "" "$NAME"
 
POL_SetupWindow_message "$POLEND" "$NAME"
 
POL_SetupWindow_Close
exit

Edited by letic

Hey Guys,

Just wondering if I did everything correctly :
- I posted my script in this post with screenshot
- I opened an account on the website to be able to post script
- Posted my script and asked for validation

I haven't got any feedback on the script itself or in the forum so I was just wondering if I followed the procedure correctly...

Thanks in advance for your answers.
LeTic

Edited by letic

I know this isn't a game script :) but this will really speed up our deployment at our customers if that script could be accepted officially...

Is there anything I should do ?

Thanks in advance
LeTic

Edited by letic

I've accepted your script but I made some changes

Hey Tinou,

Thanks for that, sorry I didn't receive the reply notifications even though I have it checked in my profile, probably some crappy spam filter from my provider.

I just have a few questions :
- Why did you remove all custom images for the install screen ?
- How can I submit the icon for the app list ?
- How do you handle upgrades ? Adwords Editor is a fast evolving application, so I was wondering what is the best course of action for it ? Do you prefer a new script for the new version of just an updated version of the same script (so I should remove the version for the script name) ?

Let me know.
Thanks
LeTic

Hi

- I removed custom image because when you resize http://www.google.com/images/logos/adwords_editor_logo.gif, it looks very bad
- The icon is set
- For the update, it depends on the kind of the update

Hey Tinou,

Thanks for the quick answer.

- I removed custom image because when you resize http://www.google.com/images/logos/adwords_editor_logo.gif, it looks very bad

Fair enough :) I had a deeper look at imagemagick to make a logo that looks a bit better, let me know what you think.

- The icon is set

Great stuff thanks a lot !

- For the update, it depends on the kind of the update

You'll find below an updated version of the script for Adwords Editor 8.5.2 (you should probably remove the version from the script name).

Also I saw you commented the Set_Wine_Version, sorry I put it because I thought it was good practice (http://www.playonmac.com/en/topic-3345-Rules_to_write_script.html) so I removed it as well.

Hope this is better.
Cheers !

#!/bin/bash
# Date: (2010-09-15  12-39)
# Last revision: (2010-11-24  11-10)
# Wine version used: 1.2
# Distribution used to test: Debian Sid 64bit
# Author: LeTic
# Licence: http://www.google.com/intl/en/adwordseditor/terms.html
# Depend:
 
[ "$PLAYONLINUX" = "" ] && exit 0
source "$PLAYONLINUX/lib/sources"
 
NAME="Adwords Editor"
PREFIX="AdwordsEditor"
URL="http://dl.google.com/adwords_editor/8.5.2/win32/en-US/adwords_editor_en-US.msi"
 
DOWNLOAD="Download in progress..."
INSTALLATION="Installation in progress..."
POLEND="$NAME has been installed succesfully"
 
wget	 http://www.google.com/images/logos/adwords_editor_logo.gif --output-document="$REPERTOIRE/tmp/leftnotscaled.gif"
convert "$REPERTOIRE/tmp/leftnotscaled.gif" -resize 150x21 -gravity center -repage 150x356+0+167 -flatten -unsharp 0x1 "$REPERTOIRE/tmp/left.jpeg"
 
wget "http://www.mozilla.org/images/projects/adwords.png" --output-document="$REPERTOIRE/tmp/topnotscaled.png"
convert "$REPERTOIRE/tmp/topnotscaled.png" -repage 60x60+5 -flatten "$REPERTOIRE/tmp/top.jpeg"
 
POL_SetupWindow_Init "$REPERTOIRE/tmp/top.jpeg" "$REPERTOIRE/tmp/left.jpeg"
 
POL_SetupWindow_presentation "$NAME" "Google Inc" "http://www.google.com/intl/en/adwordseditor/index.html" "LeTic" "$PREFIX"
 
select_prefix "$REPERTOIRE/wineprefix/$PREFIX"
POL_SetupWindow_prefixcreate
 
POL_LoadVar_PROGRAMFILES
 
#Install vcrun2005
POL_Call POL_Install_vcrun2005
POL_Call POL_Install_gecko
 
cd "$REPERTOIRE/tmp/"
 
POL_SetupWindow_download "$DOWNLOAD" "$NAME" "$URL"
POL_SetupWindow_wait_next_signal "$INSTALLATION" "$NAME"
msiexec /i adwords_editor_en-US.msi /q
POL_SetupWindow_detect_exit
 
rm adwords_editor_en-US.msi
 
convert ~/.local/share/icons/*__19536f6e05de1cfef02b79.png -scale 32x32\\! "$REPERTOIRE/icones/32/$NAME"
 
POL_SetupWindow_make_shortcut "$PREFIX" "$PROGRAMFILES/Google/Google AdWords Editor" "adwords_editor.exe" "" "$NAME"
 
POL_SetupWindow_message "$POLEND" "$NAME"
 
POL_SetupWindow_Close
exit

Edited by letic

It is not bad ;) But the rule is no imagemagick for left and top image

I just submitted a new version of the script for Adwords Editor 9.0.1 latest version.

Unfortunately I haven't found a link to the latest version on their FTP to make the script generic...

I'll try to raise the concern with them.

I also commented out the imagemagick part for the top and left because I know you don't like them :)

I made a small how-to as well : https://redmine.personalized-software.ie/projects/opensource/wiki/Adwords_Editor_for_Linux let me know what you think.

Thank you, I'm going to check it

EDIT : Sorry, but your script is not in our database

Edited by Tinou

Argh, I just changed my email address in my profile, as I never receive any notifications of your answers...

That's weird I can see it fine : http://www.playonmac.com/repository/?script=851

Do you want me to repost it ?

Edited by letic

Is it fine ? If yes, there is nothing to do

Hey Tinou,

I think there was some misunderstanding somewhere :D

You said that you were going to validate the script but that it wasn't in the DB.

Thank you, I'm going to check it

EDIT : Sorry, but your script is not in our database

But I can access it from this URL : http://www.playonmac.com/repository/?script=851

Is it fine ? If yes, there is nothing to do

Well the script is still not validated :)

Thanks in advance

Edited by letic

You did not send it to validation (The script was in editing state)

I've signed and accepted it anyway

You did not send it to validation (The script was in editing state)

Oh ok sorry about that, I was pretty sure I sent it to validation.

I've signed and accepted it anyway

Thanks a lot Tinou :)