Hi hangingman,
You're using lots of statements that are obsolete in POL 4:
- select_prefix, POL_SetupWindow_install_wine, POL_SetupWindow_prefixcreate: use POL_Wine_SelectPrefix and POL_Wine_PrefixCreate. Don't forget to remove $PREFIXDIR
- Use_WineVersion, Set_WineVersion_Assign: simply obsolete, supoorting more than one Wine version in a prefix has been dropped.
- POL_SetupWindow_make_shortcut: use POL_Shortcut instead. Full path to the binary may not be needed if there's only one exe called AxisAllies.exe in the virtual drive
TITLEC seems unused
POL_SetupWindow_menu "Which installation medium do you want to use?" "Medium" "DVD~CDROM" "~" There's a dedicated POL_SetupWindow_InstallMethod for that. The script is using the media support way before this statement, so the script behavior won't appear very logical to users, I'd put them below this line
I don't get where the axis_133.exe patch come from, seems it's expected to be in the resources but I see no download. Also, in my opinion its place is not in the resources, since it's not useful for other games (resources should be reusable).
wine axis_133.exe: calling wine directly is prohibited, use POL_Wine instead, so that debugging infos get logged. Talking of which, you should add a POL_Debug_Init right after the POL_SetupWindow_Init statement to enable debugger support
POL_SetupWindow_message "Click Forward when the installation is finished" "$TITLECOMPLETE" If the previous POL_Wine is asynchronous (probably because of the use of start /unix), try POL_Wine_WaitExit instead, it will be more user friendly (one less click)
All messages should have localized using $(eval_gettext '') method: http://www.playonmac.com/en/dev-documentation-10.html
I think you should (re)read the scripter's documentation (http://www.playonmac.com/en/documentation.html), and some recently submitted scripts as examples, as many things have changed with POL 4 (and some POL 3 statements may stop working with POL 5).
Edited by petch